Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula: add missing extend/os require #15078

Merged
merged 1 commit into from Mar 28, 2023
Merged

formula: add missing extend/os require #15078

merged 1 commit into from Mar 28, 2023

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This allows Formula#valid_platform? to work correctly on MacOS. It was left out of #15072 by accident. This meant MacOS only formulae were left out of search results.

How it should work

MacOS

/u/l/Homebrew (search-by-platform|✔) $ brew search xmount
==> Casks
mounty
/u/l/Homebrew (search-by-platform|✚1) $ brew search chisel
==> Formulae
chisel

Linux

/u/l/Homebrew (search-by-platform|✚1) $ brew search xmount
==> Formulae
xmount
/u/l/Homebrew (search-by-platform|✚1) $ brew search chisel
Error: No formulae or casks found for "chisel".

@apainintheneck
formula: add missing extend/os require
9835d1a 
This allows Formula#valid_platform? to work correctly on MacOS.
@apainintheneck apainintheneck added the critical Critical change which should be shipped as soon as possible. label Mar 28, 2023
@apainintheneck apainintheneck merged commit 3b5176a into Homebrew:master Mar 28, 2023
25 checks passed
@MikeMcQuaid
Copy link
Member

Thanks again @apainintheneck!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
@apainintheneck apainintheneck deleted the adding-missing-extend-os-formula-require branch May 14, 2023 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apainintheneck @MikeMcQuaid @BrewTestBot